Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for gride size and position #250

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Support for gride size and position #250

wants to merge 20 commits into from

Conversation

l-monnier
Copy link

Hello,

Following our discussions in issue 176, here is my pull request for Grid size and position support.
I've also performed some minor corrections to avoid GHC compiler warnings and compilation failures with older version of GHC.

Some notes:

  • I've implemented a '//' operator for the CSS '/' operator. However, this operator is used in other CSS properties (background and font are the ones I know of). So, it's not fully coherent with the rest of the library. On the other hand, I find the syntax rather nice and natural (more than using tuples, especially because I already use them when a custom-ident is combined with an Integer).
  • There are spaces between the the '/' and its parameters (1 / 2) which is not removed when rendered in compact form. However, I feel this should more be the job of the compact rendering to remove them (but maybe I'm missing something here)
  • To properly implement all the naming rules for the custom-ident is highly complex due to the escaping and Unicode rules. It would require a parser such as MegaParsec. RegExp would not really be a good solution, as it would be difficult to return valuable error messages to the user. Adding a dependency for this only purpose is not worth it in my opinion.

Let me know your thoughts.

leo added 20 commits February 28, 2023 22:22
Fix warnings linked to prefix use of '$'
9b3898d
First draft for grid items' position support
57085ab 
First draft to support the following CSS properties:
grid-row-start, grid-row-end, grid-column-start, grid-column-end,
grid-row, grid-column and grid-area.
Remove unnecessary $.
6f82db8
Clean code and improve documentation
ed216b5
Implement all checks as partial functions
9321f30
Rename functions and types for four grid-line
fb68204 
Add a `4` at the end of such data types and functions for more
consistency.
Explicit import of the sort function
d583358 
This avoids a warning from the compiler.
Create new tests
8cc3b37
Reorganise import and documentation
9ac03f1
Improve documentation and examples
52c9c96
Improve documentation
d5301e3 
Use of folding headings to make the documentation more compact.
Small fix in the documentation
c9cd189 
Added a Example heading. There is unfortunately a bug with Haddock
when trying to make the heading foldable.
Add CustomIdentGrid data type and instances
61af420 
This will allow a more finer control grain over the types and
there documentation.
Implement checks when creating custom-ident
093a38a 
The checks are for the moment only when the custom-ident is
created as a 'CustomIdent' type.
Remove type/instances constructors for GridLine
db8f9d7 
As long as there are no function implementing Either instead
of the partial functions, there is a risk for invalid value being
built by the user. Also we could later change the interface of
those functions/constructors so they return an Either value.
Add custom-ident checks for String instances
b3a2df0 
Errors are now raised when invalid custom-ident are provided,
regardless if they are provided as a String or as a CustomIdentGrid.
Merge branch 'master' of https://github.com/l-monnier/clay
64d7dd1
Correct style to avoid compilation error
970ec28 
The compilation error is with older version of GHC when compiling
with Nix.
Add change to changelog
41aa057
Correct compilation failure for old version of GHC
1859e04 
Comments of arguments where not properly formatted and lead to a
compilation failure for older version of GHC when testing the build
with Nix.
@CharlesTaylor7 CharlesTaylor7 mentioned this pull request Jul 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@l-monnier